Skip to content

Add requalify_ticket and guard the requalified envelope (0.6.0, breaking) - #12

Merged
baraline merged 2 commits into
mainfrom
feat/requalify-ticket
Nov 16, 2026
Merged

baraline merged 2 commits into
mainfrom
feat/requalify-ticket

Conversation

@baraline

Copy link
Copy Markdown
Owner

Summary

Adds requalify_ticket and names the requalified body as a workflow envelope. Release 0.6.0, which contains a breaking change.

  • Added: requalify_ticket(rfc_number, *, allow_workflow_effect, catalog_id=None, catalog_code=None, catalog_guid=None). It sends PUT requests/{rfc} with a requalified body holding exactly one catalog key. Passing no key or several raises ValueError before any request is made. The vendor documents a requalification as starting a new workflow (action.md). The method never re-reads the ticket: the caller confirms the change landed with get_ticket. One instance was measured answering HTTP 590 to an incident requalification that had in fact landed; that may not hold elsewhere.
  • Changed (BREAKING): requalified is now an UNKNOWN workflow envelope. It matches a top-level body key in any casing on any path. A raw send of a requalified body is refused unless the call allows WorkflowEffect.UNKNOWN. Before this change, the nested catalog key passed the guard unseen.
  • The send docstring and vendor-api-reference.md list requalified with the other guarded envelopes.
  • Also fixes an outdated bullet in docs/user_guide.rst that said suspend and reopen were "not wrapped here". They are wrapped since 0.5.0.

Tests

  • Full suite: 2361 passed, coverage 98.97%.
  • Clean: ruff check, unasync --check, lint_hand_written_sync, mypy, sphinx -W.
  • Tests catch each of the three required mutated versions of the guard.

Note: ruff format --check . already fails on main in files this branch does not touch. Those files are left as they are.

🤖 Generated with Claude Code

baraline and others added 2 commits November 16, 2026 12:24
…flow envelope (0.6.0), refusing a raw send of it unless allowed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…odies, in the async source and its generated sync twin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.97%. Comparing base (a269753) to head (2676933).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   98.96%   98.97%           
=======================================
  Files          40       40           
  Lines        2715     2728   +13     
=======================================
+ Hits         2687     2700   +13     
  Misses         28       28           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@baraline
baraline merged commit cd0e4c2 into main Nov 16, 2026
6 checks passed
@baraline
baraline deleted the feat/requalify-ticket branch November 16, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants